MM-50818 Fix module loading issues caused by shared modules #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
approved these changes
Feb 27, 2023
|
@lieut-data I need a minute. I forgot one part of this |
|
Okay, now it's good to go |
This was referenced Feb 28, 2023
lieut-data
approved these changes
Feb 28, 2023
|
I'm not sure why the lint job is failing here. I think it's something that's already affecting the |
|
Yep, CI on this branch isn't working yet -- feel free to merge @hmhealey :) |
hmhealey
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors that we were seeing where either Boards or Playbooks were failing to load when they were both loaded at the same time seems like it was happening due to an issue with the resolution of shared modules by module federation. Specifically, it seems to be due to how it was trying to choose which version of those shared modules to use between the ones bundled with the web app, Boards, and Playbooks.
Since I've been trying to make the web app the authority for these dependencies, I just changed it so that the Playbooks build will never include "fallback" versions of React and such since we know they'll always exist in the web app.
Ticket Link
https://mattermost.atlassian.net/browse/MM-50818
Related Pull Requests
mattermost/focalboard#4605
mattermost/mattermost-webapp#12282